Skip to content

Open/Closed Principle Violation

Sponsor: Do you build complex software systems? See how NServiceBus makes it easier to design, build, and manage software systems that use message queues to achieve loose coupling. Get started for free.

Learn more about Software Architecture & Design.
Join thousands of developers getting weekly updates to increase your understanding of software architecture and design concepts.

Before I post too many SOLID principle posts, let me prefix by saying that I strongly believing that following SOLID principles as guidelines will lead to writing better Object Oriented code. Back to Open/Close Principle
Software entities like classes, modules and functions should be open for extension but closed for modifications.
Out of all the SOLID principles, I’ve found this one to causes the most confusion and is the hardest to identify for developers.  When following any of the SOLID principles, they all have a bit of cross over that help you identify when violating one of them.  Violating Open/Close principle usually means you are also violating Single Responsibility. Here are a few smells/tips to for identifying when you might be violating Open/Closed principle:
  • Conditional Code
  • Multiple unit tests due to multiple execution paths
  • Violation of Single Responsibility
[code lang=”csharp”] // Something smells in here… public int GetSpeed() { int speed = 0; if (_type is Bike) { speed = 10; } else if (_type is Car) { speed = 70; } else if (_type is Jet) { speed = 300; } return speed; } [/code]

Leave a Reply

Your email address will not be published. Required fields are marked *